k-wave-python icon indicating copy to clipboard operation
k-wave-python copied to clipboard

Refactor ktransducer

Open faridyagubbayli opened this issue 1 year ago • 3 comments

Towards #436

Moved active_elements, transmit_apodization, receive_apodization and related methods to the kWaveTransducerSimple while ensuring backwards compatibility. This is part of the effort to refactor the ktransducer.py.

faridyagubbayli avatar Jul 09 '24 09:07 faridyagubbayli

@waltsims @djps can you have a look and comment on the direction? If the direction looks good, I'll go ahead and update the examples to use the new structure.

faridyagubbayli avatar Jul 09 '24 09:07 faridyagubbayli

Codecov Report

Attention: Patch coverage is 69.64286% with 17 lines in your changes missing coverage. Please review.

Project coverage is 71.90%. Comparing base (98b0d26) to head (18daf0a).

Files Patch % Lines
kwave/ktransducer.py 69.64% 14 Missing and 3 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
+ Coverage   71.84%   71.90%   +0.05%     
==========================================
  Files          46       46              
  Lines        6744     6776      +32     
  Branches     1496     1503       +7     
==========================================
+ Hits         4845     4872      +27     
- Misses       1334     1337       +3     
- Partials      565      567       +2     
Flag Coverage Δ
3.10 72.10% <69.64%> (+0.05%) :arrow_up:
3.11 72.10% <69.64%> (+0.05%) :arrow_up:
3.12 72.10% <69.64%> (+0.05%) :arrow_up:
3.9 71.87% <69.64%> (+0.05%) :arrow_up:
macos-latest 71.84% <69.64%> (+0.05%) :arrow_up:
ubuntu-latest 71.87% <69.64%> (+0.05%) :arrow_up:
windows-latest 71.88% <69.64%> (+0.05%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 09 '24 09:07 codecov[bot]

@faridyagubbayli how do you plan to make this backwards compatible?

waltsims avatar Jul 12 '24 03:07 waltsims