k-wave-python icon indicating copy to clipboard operation
k-wave-python copied to clipboard
verified publisher icon waltsims

[ENHANCE] Improve structure in transducer related classes

Open faridyagubbayli opened this issue 1 year ago • 0 comments

Description of the Enhancement

Two classes for representing and working with transducer, kWaveTransducerSimple and NotATransducer, can be improved in terms of code structure and clarity.

Justification for the Enhancement

  1. Currently, the boundary between the transducer and it's usage is not clear.
  2. Naming of the classes are not the best. We chose these names back then for the sake of time efficieny but it is time to improve this.
  3. Clear separation will help with writing tests and overall code quality.

Impact of Changes

Better naming, clear ownership of the properties and separation between definition and usage of the transducer.

Screenshots/Examples

Additional Context

faridyagubbayli avatar Jul 09 '24 08:07 faridyagubbayli