k-wave-python icon indicating copy to clipboard operation
k-wave-python copied to clipboard

Refactor make_line

Open faridyagubbayli opened this issue 1 year ago • 3 comments

Closes #263

Splits the long make_line function into two new functions. The first function handles drawing straight lines while the second draws lines with angle.

  • [ ] Add "edge case" tests

faridyagubbayli avatar Apr 23 '24 16:04 faridyagubbayli

Codecov Report

Attention: Patch coverage is 64.22764% with 44 lines in your changes missing coverage. Please review.

Project coverage is 71.80%. Comparing base (2e0bd5c) to head (8b5eee1).

:exclamation: Current head 8b5eee1 differs from pull request most recent head 34d5764

Please upload reports for the commit 34d5764 to get more accurate results.

Files Patch % Lines
kwave/utils/mapgen.py 64.22% 32 Missing and 12 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
+ Coverage   71.59%   71.80%   +0.21%     
==========================================
  Files          46       46              
  Lines        6738     6697      -41     
  Branches     1496     1487       -9     
==========================================
- Hits         4824     4809      -15     
+ Misses       1345     1321      -24     
+ Partials      569      567       -2     
Flag Coverage Δ
3.10 72.01% <64.22%> (+0.21%) :arrow_up:
3.11 72.01% <64.22%> (+0.21%) :arrow_up:
3.12 72.01% <64.22%> (+0.21%) :arrow_up:
3.9 71.78% <64.22%> (+0.21%) :arrow_up:
macos-latest 71.74% <64.22%> (+0.21%) :arrow_up:
ubuntu-latest 71.77% <64.22%> (+0.21%) :arrow_up:
windows-latest 71.79% <64.22%> (+0.21%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 23 '24 17:04 codecov[bot]

@copilot add edge cases tests

waltsims avatar Nov 12 '25 14:11 waltsims

@waltsims I've opened a new pull request, #648, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot avatar Nov 12 '25 14:11 Copilot