k-wave-python icon indicating copy to clipboard operation
k-wave-python copied to clipboard

[WIP] Benchmarks

Open djps opened this issue 1 year ago • 4 comments

As a work in progress, can't be merged, but

  • What figures and analysis should be performed?

As it is not part of the k-wave example set things are less well-defined.

djps avatar Feb 25 '24 21:02 djps

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 67.78%. Comparing base (0911060) to head (c819b31).

Files Patch % Lines
kwave/utils/filters.py 66.66% 6 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   67.76%   67.78%   +0.02%     
==========================================
  Files          48       48              
  Lines        7066     7071       +5     
  Branches     1605     1605              
==========================================
+ Hits         4788     4793       +5     
- Misses       1697     1698       +1     
+ Partials      581      580       -1     
Flag Coverage Δ
3.10 67.94% <66.66%> (+0.02%) :arrow_up:
3.11 67.94% <66.66%> (+0.02%) :arrow_up:
3.12 67.94% <66.66%> (+0.02%) :arrow_up:
3.9 67.75% <66.66%> (+0.02%) :arrow_up:
ubuntu-latest 67.72% <66.66%> (+0.02%) :arrow_up:
windows-latest 67.72% <66.66%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 25 '24 21:02 codecov[bot]

Since it is a benchmark a description of the benchmark with a link to the paper, one figure and a table with the performance results would be a good place to start. What do you think?

waltsims avatar Feb 25 '24 22:02 waltsims