Jun Duan
Jun Duan
> In the log in [#1851 (comment)](https://github.com/kubestellar/kubestellar/issues/1851#issuecomment-2332166094) , in the Job starting at line 1087, the ManagedFields shows the whole `.status` --- including `.status.ready` --- owned by the FieldManager named...
> > Maybe the package pkg/metrics was born for metrics, but now I see many more general stuff here in the package. > > What do you see in that...
Thanks for @njhill 's review! I absolutely agree the @njhill suggested 'fail request when sleeping' feature is good to do. I think the probe currently implemented in the PR is...
> @waltforme actually could you add a test for this? Probably just adding something to https://github.com/vllm-project/vllm/blob/main/tests/entrypoints/openai/test_sleep.py should suffice. @njhill Absolutely. Added into the suggested file. Thanks for checking this!
> not sure if this is a standard elsewhere, but we can follow k8s health API endpoint for this fwiw. (i also responded in the ticket) @aarnphm Thanks for the...
@aarnphm Thanks! I responded in the PR.
Regarding the sleeping engine crash by sending a request, I completely agree. @njhill also talked about this here https://github.com/vllm-project/vllm/pull/14312#issuecomment-2721588578. I think the plumbing introduced by #14312 can be conveniently utilized...
The initial and main concern of this issue is resolved, closing. For the [separate issue](https://github.com/kubestellar/kubestellar/issues/2532#issuecomment-2449091093) which is not resolved yet, I opened https://github.com/kubestellar/kubestellar/issues/3286 to keep track of it.
I tried to reproduce the bug but somehow successfully ran two jobs. ### Some setup details I was using KS version `0.25.0-rc.1`. ```console $ git log -1 commit b464cf3b9aef78f8c98960beb33befa1cd1f191d (HEAD,...