google-drive-sync icon indicating copy to clipboard operation
google-drive-sync copied to clipboard

Duplicated "Enable Legacy Oauth" section

Open dregad opened this issue 4 years ago • 4 comments

Describe the bug In the Configuration dialog, the Enable Legacy Oauth 2.0 Credentials section is present under both the Sync Authorization and Options and Defaults tab

To Reproduce Steps to reproduce the behavior:

  1. Go to Tools > KPSync > Configure
  2. Notice Legacy Oauth section at bottom
  3. Click on Options and Defaults tab
  4. Notice duplicated section

Expected behavior Only a single occurence is required, or am I missing something ?

Screenshots Unnecessary I guess, but if you need them let me know

Please complete the following information:

  • OS: Windows 10, version 1909 build 18363.1440
  • Browser N/A
  • Version 4.0.6-beta

Additional context N/A

dregad avatar Mar 29 '21 13:03 dregad

As a side note, when the Enable checkbox is not checked, the Help and Google Developer Console links at the bottom remain visible as non-actionable text. Maybe they should be hidden instead, to avoid confusion.

dregad avatar Mar 29 '21 13:03 dregad

The Options and Defaults tab contains controls for configuring plugin options affecting usage with all existing databases, and future databases. A user who wants to use the same personal OAuth 2.0 creds for every database created in the future, would enter those credentials there. If, on the other hand, a user wanted to change the personal OAuth 2.0 creds for the currently open database, they would use the similar controls of the Sync Authorization tab.

Given that personal OAuth 2.0 creds support is a DEPRECATED feature, perhaps the issue could be rephrased in those terms, e.g., "Remove deprecated features from 'Options and Defaults' configuration controls".

Anyone else interested in this feature/bug care to comment?

walterpg avatar Apr 25 '21 00:04 walterpg

perhaps the issue could be rephrased in those terms, e.g., "Remove deprecated features from 'Options and Defaults' configuration controls".

Fine with me

Anyone else interested in this feature/bug care to comment?

Guess not 😉

dregad avatar May 20 '21 16:05 dregad

Anyone else interested in this feature/bug care to comment?

Guess not 😉

There is still interest in deprecated features (#42), however I don't think removing the "default for new databases" in this case would distract from that.

I could be mistaken.

walterpg avatar May 21 '21 00:05 walterpg