ScriptCraft icon indicating copy to clipboard operation
ScriptCraft copied to clipboard

Drone uses block.setTypeIdAndMetadata method that doesn't exist in 1.13

Open jwulf opened this issue 6 years ago • 4 comments

This method was deprecated and has been removed in 1.13. See: https://bukkit.org/threads/moving-blocks-settypeidanddata-deprecated.299908/

Executing js rainbow() in 1.13 gives errors like this:

Drone build error: TypeError: block.setTypeIdAndData is not a function while processing function wrapperFn() { [native code] }

jwulf avatar Jan 19 '19 16:01 jwulf

https://www.spigotmc.org/threads/1-13-set-type-and-id-to-block.342478/

jwulf avatar Jan 19 '19 16:01 jwulf

The Drone module needs some work to be compatible with 1.13. Many of the functions which use drone (e.g. cottage, castle, fort etc) no longer place blocks correctly. For example, beds, ladders, doors, windows etc all are placed incorrectly now. I'll try to get to this at some stage - if anyone wants to help please feel free to PR.

walterhiggins avatar Jan 28 '19 09:01 walterhiggins

@jwulf you should try ScriptCraft 3.4.0 (or the development branch), since it includes my patch (#388) that works around the removal of block.setTypeIdAndData. This makes the Drone able to place blocks again, but as @walterhiggins mentions here, there are several little things that are still broken.

jonathanperret avatar Feb 03 '19 21:02 jonathanperret

That did work @jonathanperret , but it's now broken on 1.15.2, as CraftEvil is not available.

jwulf avatar Jan 28 '20 02:01 jwulf