ScriptCraft icon indicating copy to clipboard operation
ScriptCraft copied to clipboard

Add missing blocks from 1.10/1.11/1.12

Open Gloorf opened this issue 8 years ago • 5 comments

Also removes duplicates & trailing whitespace in the blocks definitions

Gloorf avatar Sep 23 '17 20:09 Gloorf

I'd take it but @walter is strongly adverse to whitespace changes, so you'll have to wait for his decision on a few of the lines.

TonyGravagno avatar Sep 27 '17 03:09 TonyGravagno

I'm just removing a couple of trailing whitespaces (because usually there is none in the file), i'm not changing the whole indentation scheme of the document :)

Gloorf avatar Sep 27 '17 10:09 Gloorf

Hi @Gloorf If you can reinstate stone and fence I'm happy to merge this.

walterhiggins avatar Sep 30 '17 14:09 walterhiggins

stone (actually it's slab.stone) is already defined line 98 : https://github.com/walterhiggins/ScriptCraft/blob/development/src/main/js/modules/blocks.js#L98 and fence is actually overwritten by the fence object on line 323 : https://github.com/walterhiggins/ScriptCraft/blob/development/src/main/js/modules/blocks.js#L323 so it was never used anyway. I fixed the fence object itself (correct data value for oak, added dark oak & nether brick fence)

Gloorf avatar Oct 01 '17 07:10 Gloorf

Looks fine to me, although I'd have picked fence.netherbrick over fence.nether_brick since we already have slab.netherbrick.

jonathanperret avatar Aug 02 '18 21:08 jonathanperret