dyn-edn icon indicating copy to clipboard operation
dyn-edn copied to clipboard

Published 20 hours ago • verified publisher icon walmartlabs

Treat properties the same way as enviroment variables

Open bonega opened this issue 6 years ago • 7 comments

Based on the wording it seems like properties is intended to take a different code-path. I don't know why though. My use case is to #dyn/prop SOME_NAME and provide the value with either env variables or properties. This can't be accomplished without escaping in master.

bonega avatar Oct 29 '18 12:10 bonega

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 29 '18 12:10 CLAassistant

Ignore this for another day, found something embarrassing.

bonega avatar Oct 30 '18 17:10 bonega

Should be ok now.

bonega avatar Oct 31 '18 13:10 bonega

Sorry for the long delay, as I mentioned elsewhere, I didn't have my GitHub notifications set up very well.

hlship avatar Jan 18 '19 21:01 hlship

I would prefer to see doc changes, and tests (even for a trivial change like this). I'm also concerned about properties in the property map having punctuation that makes them bad choices for symbols.

hlship avatar Jan 18 '19 21:01 hlship

Again, I'd like to commit this but w/o doc changes and tests that's just not going to happen.

hlship avatar Aug 09 '19 16:08 hlship

A bit swamped at the moment but I will try and make some time. I had a look at the property map and I think it should be okay. Symbols are quite resistant to many usual chars, of the top of my head the problematic ones is :,;,, I will make a test proving or disproving symbol parse.

bonega avatar Aug 14 '19 15:08 bonega