cookie-cutter icon indicating copy to clipboard operation
cookie-cutter copied to clipboard

Azure Queue Sink does not turn milliseconds into seconds like source does

Open cross311 opened this issue 4 years ago • 3 comments

Azure Queue expects the visibility timeout to be in seconds... however most things in cookie cutter take in milliseconds. So in the source we turn milliseconds from the constructor and turn in the seconds. However in the sink where we actually set the visibility timeout when creating a new message, we pass it straight in.

REQUEST: please take in Milliseconds like everywhere else and turn it in to seconds to hide the underlying library from consumers.

cross311 avatar Apr 08 '20 23:04 cross311

makes sense, we should probably add new metadata fields then to ensure this remains backwards compatible.

sklose avatar Apr 14 '20 19:04 sklose

Added VisibilityTimeoutMs and TimeToLiveMs fields to the metadata for use with calls to publish and store (when directly setting the metadata fields). Will keep the old ones for compatibility.

plameniv avatar May 05 '20 14:05 plameniv

Reopening, since the main concern hasn't been addressed.

We fixed a breaking API change to Azure Queues. The config passed to the Queue constructor is back to expecting seconds.

plameniv avatar May 28 '20 14:05 plameniv