cookie-cutter icon indicating copy to clipboard operation
cookie-cutter copied to clipboard

Encoder Returns Wrong Type

Open sklose opened this issue 5 years ago • 0 comments

ProtoMessageEncoder should return a UInt8Array instead of a Buffer object (the TypeScript typedef files of the underlying library are wrong). This will be breaking change for new data, we need to ensure we support reading data in the old format to preserve backwards compatibility.

Also ProtoMessageEncoder should implement the IEmbedder interface and render out into a base64 string.

sklose avatar Nov 25 '19 18:11 sklose