concord icon indicating copy to clipboard operation
concord copied to clipboard

chore: use mvnw wrapper jars

Open ajayk opened this issue 2 years ago • 3 comments

ajayk avatar Jul 24 '22 01:07 ajayk

@ajayk sorry for a late follow-up, but what is the reason MavenWrapperDownloader.java is replaced with the JAR? Is that the current preferred way of putting mvnw into repos?

ibodrov avatar Aug 31 '22 13:08 ibodrov

@ibodrov : @jvanzyl archived the takari wrapper https://github.com/takari/maven-wrapper and the path is to use the https://github.com/apache/maven-wrapper

@jvanzyl any recommendations here ?

ajayk avatar Sep 01 '22 17:09 ajayk

I usually just use the JAR

jvanzyl avatar Sep 01 '22 17:09 jvanzyl

The script downloads the JARs anyway, let's not commit binaries -- might cause issues wrt Walmart environments.

ibodrov avatar Oct 16 '23 14:10 ibodrov