concord icon indicating copy to clipboard operation
concord copied to clipboard

ansible: the runtime-v1 version shouldn't use v2 types

Open ibodrov opened this issue 4 years ago • 0 comments

Currently the task re-uses TaskResult from the concord-v2 runtime for the common code that can be called from both v1 and v2 runtimes. Due to breaking changes in 1.71.0, this might cause errors like so:

java.lang.InstantiationError: com.walmartlabs.concord.runtime.v2.sdk.TaskResult
	at com.walmartlabs.concord.plugins.ansible.AnsibleTask.run(AnsibleTask.java:153)
	at com.walmartlabs.concord.plugins.ansible.v1.RunPlaybookTask2.run(RunPlaybookTask2.java:127)

We need to change the task to not to use v2 types in common code bits and avoid situations like this in future.

ibodrov avatar Dec 07 '20 19:12 ibodrov