Oskar Gewalli

Results 175 comments of Oskar Gewalli

I agree. It only makes sense to align with the libraries. Right now JNumber active pattern has some interesting behavior.

We also see this kind of behavior: https://github.com/JamesNK/Newtonsoft.Json/issues/1400 So I guess it's a tradeoff what Json parser you use.

I've added a PR that documents the behavior. Note that Fsharp.Data works the way you want.

I think that sounds like different use case than what Fleece is supposed to solve?

The tests that execute are the same as can be found for other implementations, there are some ifdefs in the source: Note the references in fsproj here: https://github.com/fsprojects/Fleece/blob/v0.9.0/test/Tests.FSharpData/Tests.FSharpData.fsproj#L9-L10 The ifdefs...

You could use the F#5 functionality as well since this isn't sufficient complexity to warrant paket.

I think it would make sense to change to .net 5 in order to be able to improve the docs.

This library uses Fuchu for tests. We could adjust Fuchu to run on both Fable and .net.

That's an interesting question. One way to do it would perhaps be to have ofJson and toJson separated from the types in order to be able to invoke the correct...