PEPS icon indicating copy to clipboard operation
PEPS copied to clipboard

Add HTTP(S) proxy support in the build process

Open trexmaster opened this issue 10 years ago • 3 comments

I had to manually edit the Dockerfiles to add the environment variables to use the HTTP proxies, it'd be nice if the Makefile could just get them from the running environment and pass them to the rest of the components.

trexmaster avatar Feb 19 '15 12:02 trexmaster

Can you submit a pull request?

hbbio avatar Feb 19 '15 14:02 hbbio

I'm not used to git so I'll answer with maybe :) I've forked the project, so I'll try to work there and when I'm confident enough I can make a pull request without breaking stuff I'll do it.

As a side note, I just found out that Docker is in the process of adding build-time environment variables (see https://github.com/docker/docker/pull/9176) which would probably solve this issue, or at least help a great deal.

Edit : Ah ! Turns out forking's exactly what I was supposed to do :D

trexmaster avatar Feb 19 '15 15:02 trexmaster

Yes, a few new Docker features would definitely help! Also, we reviewed wether the added complexity of running etcd in containers would be a better replacement for all configuration currently in /etc/peps but decided to wait until things stabilize a bit on the Docker side.

And we will review pull requests anyway.

hbbio avatar Feb 19 '15 16:02 hbbio