unorm icon indicating copy to clipboard operation
unorm copied to clipboard

Published 20 hours ago • verified publisher icon walling

Uglified version crashes in IE8

Open mlarcher opened this issue 9 years ago • 2 comments

unorm fails on reduceRight in IE8, preventing all following code from running when in concatenated bundle. cf https://developer.mozilla.org/fr/docs/Web/JavaScript/Reference/Objets_globaux/Array/reduceRight#Browser_compatibility

mlarcher avatar Oct 08 '15 15:10 mlarcher

any ETA for a fix on this issue ? It seems to me it is just a matter of implementing an IE8 compatible function that would emulate reduceRight.

mlarcher avatar Nov 04 '15 18:11 mlarcher

I'm inclined to not solve this. I think it's reasonable to include shims (reduceRight) for IE8 support, since the user base is quite small and declining. I don't want to increase the code size too much to support IE8. Maybe it should be better documented.

On the other hand, if you have time to submit a PR that removes the dependency on reduceRight it might be a good solution, and I will be happy to merge it. Have you tested that the reduceRight shim solves the issue?

walling avatar Nov 06 '15 14:11 walling