wallabagger
wallabagger copied to clipboard
wallabag
Use `page_action` instead of `browser_action`
I think it would be more consistent to use page_action instead of browser_action (eg moving the icon in the address bar):
- The wallabag icon would be closer to the bookmark icon
- It's a conceptually similar to bookmarking, so it feels like it belongs in the address bar as well
- Pocket will work this way in future versions of Firefox:
@NicolasPetton I'm not sure about this. The documentation says:
If your extension provides the user with features they can use on almost every website [...] use browser action. If your extension offers a feature for a type of web page [...] use page action
As far as I know, any URL can be sent to Wallabag.
Do you have any reference explaining why Pocket would go in the address bar?
@tcitworld Do you have examples of "when it's not relevant"? They might support the suggestion of @NicolasPetton.
I think the Pocket icon is in the address bar to be physically close to the bookmark icon, which makes a lot of sense from the user perspective.
It looks like this in FF Nightly (57.0a1):
in FF (55.0.2)
in Vivaldi browser (1.12.936.3) also
in Opera (47.0.2631.55)
BUT
it seems that Chrome itself stop showing icons inside address bar in the latest builds
https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-extensions/upcoming/chromium-extensions/7As9MKhav5E/dNiZDoSCCQAJ
( 60.0.3112.101 )
canary ( 62.0.3193.0 )
and Yandex browser too, while its owns icons are shown
Let's hope they return it.
There is this place in nightly:
To remember: The Wallabag icon currently has a context menu whose actions are not related at all to the current page such as "Unread articles".
but chrome can't :disappointed:
Google says:
- Do use page actions for features that make sense for only a few pages.
- Don't use page actions for features that make sense for most pages. Use browser actions instead. [Source]
Mozilla says:
Use a page action when the action is related to the current page, and a browser action when the action is related to the browser as a whole or too many pages. [Source]
Page actions are for actions that are only relevant to particular pages (such as "bookmark the current tab"). If they are relevant to the browser as a whole (such as "show all bookmarks"), use a browser action instead. [Source]
Looking at Google's advice, browser action seems most appropriate. Firefox's advice is a little more ambiguous; "bookmarking the current tab" is very close to Wallabagger's main use case, but at the same time the current action does do more than just interact with the current page.
Maybe having just a page action would be a neat way of implementing #125 (Option to disable popup), while keeping the current browser action as the default.
Looks like someone went for this last month as a separate extension. https://addons.mozilla.org/en-GB/firefox/addon/wallabaggerini/
