wallabag icon indicating copy to clipboard operation
wallabag copied to clipboard

Unable to upgrade to Wallabag 2.6.2

Open jameswill opened this issue 1 year ago • 27 comments

Environment

  • Version: 2.6.2
  • Installation: downloaded Package
  • PHP version: 7.4
  • Database: 5.7.22
  • Parameters:
My app/config/parameters.yml is:
# This file is auto-generated during the composer install
parameters:
    database_driver: pdo_mysql
    database_host: localhost
    database_port: null
    database_name: wall480
    database_user: wall480
    database_password: i!I9Tp8S.28
    database_path: null
    database_table_prefix: wlyo_
    database_socket: null
    database_charset: utf8mb4
    domain_name: 'http://[[Domain]]/wall480/web'
    server_name: 'Wallabag'
    mailer_transport: smtp
    mailer_user: null
    mailer_password: null
    mailer_host: 127.0.0.1
    mailer_port: false
    mailer_encryption: null
    mailer_auth_mode: null
    locale: en
    secret: oslbi3l4asanpk0eoa66fwhj2ajrpd
    twofactor_auth: true
    twofactor_sender: [email protected]
    fosuser_registration: true
    fosuser_confirmation: true
    fos_oauth_server_access_token_lifetime: 3600
    fos_oauth_server_refresh_token_lifetime: 1209600
    from_email: [email protected]
    rss_limit: 50
    rabbitmq_host: localhost
    rabbitmq_port: 5672
    rabbitmq_user: guest
    rabbitmq_password: guest
    rabbitmq_prefetch_count: 10
    redis_scheme: tcp
    redis_host: localhost
    redis_port: 6379
    redis_path: null
    redis_password: null
    sentry_dsn: null

What steps will reproduce the bug?

I am facing following issue while upgrading the wallabag 2.5.4 to 2.6.2

Fatal error: Declaration of Wallabag\UserBundle\Controller\RegistrationController::registerAction(Symfony\Component\HttpFoundation\Request $request) must be compatible with FOS\UserBundle\Controller\RegistrationController::registerAction(Symfony\Component\HttpFoundation\Request $request): Symfony\Component\HttpFoundation\Response in [[PATH]]/src/Wallabag/UserBundle/Controller/RegistrationController.php on line 10

Is this happening because the upgraded package still has old parameters.php ?

jameswill avatar Jul 25 '23 11:07 jameswill

Where did you go to got that error? On which page?

j0k3r avatar Jul 25 '23 12:07 j0k3r

I have overwrite all the new files on previous files (safeguarded parameters.php) and tried accessing admin panel and got this error.

jameswill avatar Jul 26 '23 04:07 jameswill

@jameswill could you update your parameters.yml file by comparing with https://github.com/wallabag/wallabag/blob/2.6.2/app/config/parameters.yml.dist ?

And tell us if the bug still occurs.

nicosomb avatar Aug 03 '23 12:08 nicosomb

Hello @nicosomb ,

I am getting the same issue with 2.6.3 .

Get this even after updating the parameters.yml after comparing with the latest parameters.yml.dist. i.e removing

    mailer_transport: smtp
    mailer_user: null
    mailer_password: null
    mailer_host: 127.0.0.1
    mailer_port: false
    mailer_encryption: null
    mailer_auth_mode: null
    twofactor_auth: true

and adding mailer_dsn: 'smtp://127.0.0.1'

in parameters.yml

But still after visiting the admin url I get the same issue.

My parameters.yml file looks similar to this i.e the default parameters.yml file :

parameters:

    database_driver: pdo_mysql
    database_host: 127.0.0.1
    database_port: null
    database_name: wallabag
    database_user: root
    database_password: null
    database_path: null
    database_table_prefix: wallabag_
    database_socket: null
    database_charset: utf8mb4
    domain_name: 'https://your-wallabag-instance.wallabag.org'
    server_name: 'Your wallabag instance'
    mailer_dsn: 'smtp://127.0.0.1'
    locale: en
    secret: CHANGE_ME_TO_SOMETHING_SECRET_AND_RANDOM
    twofactor_sender: [email protected]
    fosuser_registration: true
    fosuser_confirmation: true
    fos_oauth_server_access_token_lifetime: 3600
    fos_oauth_server_refresh_token_lifetime: 1209600
    from_email: [email protected]
    rss_limit: 50
    rabbitmq_host: localhost
    rabbitmq_port: 5672
    rabbitmq_user: guest
    rabbitmq_password: guest
    rabbitmq_prefetch_count: 10
    redis_scheme: tcp
    redis_host: localhost
    redis_port: 6379
    redis_path: null
    redis_password: null
    sentry_dsn: null

Is there anything which I am missing out on . Any resolution for the same ?.

Kindly let me know.

jameswill avatar Aug 22 '23 11:08 jameswill

@lapineige it's the same bug than yours https://github.com/YunoHost-Apps/wallabag2_ynh/pull/171#issuecomment-1661029906

nicosomb avatar Aug 22 '23 11:08 nicosomb

Just in case, @jameswill do you use Yunohost ?

lapineige avatar Aug 22 '23 12:08 lapineige

@nicosomb how do you know it ? I don't get it.

The parameter file should be the same as we don't change it as far as I can see 🤔

lapineige avatar Aug 22 '23 12:08 lapineige

Because you both have this error Fatal error: Declaration of Wallabag\UserBundle\Controller\RegistrationController::registerAction(Symfony\Component\HttpFoundation\Request $request) must be compatible with FOS\UserBundle\Controller\RegistrationController::registerAction(Symfony\Component\HttpFoundation\Request $request): Symfony\Component\HttpFoundation\Response in [[PATH]]/src/Wallabag/UserBundle/Controller/RegistrationController.php on line 10

nicosomb avatar Aug 22 '23 12:08 nicosomb

Oh I see, I didn't make the connection, as it was php7.4 and not a php version migration.

So that is an issue with the migration with php7.4 as a base… I remember in the past that we had issue upgrading php between 7.x versions, that was similar I think.

lapineige avatar Aug 22 '23 13:08 lapineige

Hello @nicosomb ,

Getting same with upgrading from 2.5.4 to 2.6.4 as well .

Just in case, @jameswill do you use Yunohost ?

@lapineige no I don't. I use shared hosting.

jameswill avatar Aug 23 '23 14:08 jameswill

@jameswill can you by any chance upgrade your PHP version?

j0k3r avatar Aug 24 '23 13:08 j0k3r

Hi,

Tried on PHP 8.0 and 8.1 and getting the same issue.

jameswill avatar Aug 29 '23 08:08 jameswill

@jameswill do you still have the issue with wallabag 2.6.6?

Kdecherf avatar Sep 14 '23 14:09 Kdecherf