wallabag icon indicating copy to clipboard operation
wallabag copied to clipboard
verified publisher icon wallabag

Add TwigCS

Open yguedidi opened this issue 3 years ago • 3 comments

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documentation no
Translation no
CHANGELOG.md no
License MIT

Enforce coding standard for Twig templates

  • [x] fix all violations
  • [x] to update after 2.5.0 release
  • [x] wait for #5761 and #5810 to be merged
  • [x] wait for #5839 to be merged
  • [ ] wait for #5782 to be merged

yguedidi avatar Apr 28 '22 23:04 yguedidi

Is coding standard for Twig something that may interest you?

yguedidi avatar Apr 28 '22 23:04 yguedidi

I think it could be a good thing.

nicosomb avatar Apr 29 '22 07:04 nicosomb

@Kdecherf @nicosomb @j0k3r ready for another review!

yguedidi avatar Jun 05 '22 10:06 yguedidi

@Kdecherf @nicosomb @j0k3r rebased on latest 2.6.0 branch

yguedidi avatar Aug 15 '22 16:08 yguedidi

Great, can you squash?

j0k3r avatar Aug 22 '22 18:08 j0k3r

@j0k3r just updated on latest 2.6.0 and squash the fix commits into a single one

yguedidi avatar Aug 24 '22 21:08 yguedidi