docker icon indicating copy to clipboard operation
docker copied to clipboard

Fix nginx.conf for reverse-proxy with HTTPS

Open hwiorn opened this issue 3 years ago • 5 comments

Related #77, #264.

This PR changes the nginx.conf of wallabag-docker to enable fastcgi HTTPS especially in case of reverse-proxy settings.

The idea is came from @blopware 's workaround and https://serverfault.com/a/527809.

hwiorn avatar May 22 '21 16:05 hwiorn

@Kdecherf @j0k3r I tested this PR and I confirm it fixes #77 Tested several scenarios:

  • Direct connection to Wallabag Docker (HTTP) => OK
  • Traefik (HTTPS reverse proxy) => Wallabag Docker (HTTP) => OK

There are several issues in wallabag android app caused by #77 that will be fixed too.

ngosang avatar Aug 29 '21 03:08 ngosang

This fixed some of my issues when putting this Docker container behind a reverse proxy, but Wallabag is still mangling URLs (e.g. dropping port number for no reason)

Hodapp87 avatar Sep 07 '21 13:09 Hodapp87

@j0k3r could you include this in the next release?

ngosang avatar Jul 27 '22 17:07 ngosang

I don't know how GitHub PR automation works but it seems they need 1 more approved review to proceed with merging. I already did it, maybe someone else could try to do it too?

LeonardoMantovani avatar Jul 29 '22 15:07 LeonardoMantovani

I got HTTP redirection loop like this https://mydomain/ -> http://mydomain/login -> https://mydomain/ This caused the Unknown error: Too many follow-up requests: 21 error on Android app upon login This fixed the redirect issue with nginx->podman container setup and I hope this to be merged

Cycatz avatar Oct 10 '22 16:10 Cycatz

I can confirm, this fix worked. Pls bring this PR into main

GeorgFoc avatar Oct 25 '22 12:10 GeorgFoc

@Kdecherf could you merge?

ngosang avatar Oct 26 '22 09:10 ngosang

@wallabag/core could you merge? This PR is really important to make Reverse Proxies to work. It's tested by me.

ngosang avatar Oct 28 '22 10:10 ngosang