Add a gesture function to the scrollview to insert the zoom-in out function.

[saechimdaeki]

Add a gesture function to the scroll view to insert the zoom-in out function.

[saechimdaeki]

This pull_request is an attempt to make this app more convenient. #854

[tcitworld]

What's android-zoom-view.jar ? https://github.com/Polidea/android-zoom-view ?

[saechimdaeki]

@tcitworld https://code.google.com/archive/p/android-zoom-view/downloads I did various tests using this library, but I didn't use it in the end. I forgot to delete it. I'm sorry. i will remove that

[saechimdaeki]

Unnecessary libraries have been removed.

[di72nn]

It's not in the build.gradle, but the jar is still there.

[saechimdaeki]

@di72nn Sorry, I forgot to find it in Branch when I did it on another computer. It has now been deleted.

[saechimdaeki]

I usually watch game community sites often.But the files on the site sometimes look too small, so I added them because I needed an extension. I'm sorry for the mess.

[di72nn]

So you only need to zoom in on some particular details, not for a whole article? Maybe it would be better to implement this as a temporary zoom that snaps back to the normal size as soon as you let it go?

[saechimdaeki]

Then shall I add it as you say? If that's better and you don't mind.

[di72nn]

@tcitworld @Strubbl @NWuensche do you think we need such a feature?

It seems the implementation can be pretty compact, so I have no strong feelings one way or the other.

[saechimdaeki]

If you guys say it's okay, I'll try.If not, I won't. Tell me without reserve.

[Strubbl]

I like the idea of the feature since i have some articles, which have graphics, where i cannot zoom in from wallabag. So i go to the original website and look for the pic.

Maybe it would be better to implement this as a temporary zoom that snaps back to the normal size as soon as you let it go?

This sounds like a solution to the described problem.

[di72nn]

@saechimdaeki thank you for your work and your continued effort to fix it, but I think that if we decide to have this feature it would be better if I make a new PR based on yours with some changes I'd like to make. I would of course credit you for the initial idea and implementation.

@Strubbl

I like the idea of the feature since i have some articles, which have graphics, where i cannot zoom in from wallabag. So i go to the original website and look for the pic.

Note that this way of implementing it seems to be doing simple scaling - it scales already rendered image - so no extra pixels. Particularly for images it may be better to try to implement "tap to open" (I think there's an issue for that).

[Strubbl]

so no extra pixels

In my use case this would be okay because the image embedded to the article was scaled down. So in theory the pixels are already there if i could zoom in. I do not know if the simple scaling would only zoom into the smaller rendered image or if it zooms into the original image.

[di72nn]

would only zoom into the smaller rendered image or if it zooms into the original image

The smaller rendered one.

[Strubbl]

In that case the feature is useless.

[saechimdaeki]

Speaking of words, I tried. Now let go of your finger and it will return to its original size.