android-app icon indicating copy to clipboard operation
android-app copied to clipboard

Published 20 hours ago • verified publisher icon wallabag

WIP: Replace app icon

Open di72nn opened this issue 6 years ago • 11 comments

Icons with padding.

As I mentioned earlier, some icons have problems with aliasing.

di72nn avatar Oct 29 '17 09:10 di72nn

Yay! So glad you're working on this. Should I close #638 in favor of this?

lokesh-krishna avatar Dec 01 '17 09:12 lokesh-krishna

Tested in Android 7.0. It looks good but I don't like the padding around the icon (in my xiaomi is white around the grey icon).

ngosang avatar Mar 03 '18 15:03 ngosang

@ngosang Could you please test the icon provided in #638?

lokesh-krishna avatar Mar 03 '18 15:03 lokesh-krishna

I did and now I don't have a clear mind about that... screenshot_2018-03-03-20-23-42-631_com miui home screenshot_2018-03-03-16-21-07-306_com miui home

ngosang avatar Mar 03 '18 19:03 ngosang

I would love this PR merged with the padding. Debug icons??

ngosang avatar Mar 10 '18 19:03 ngosang

@lokesh-krishna would it be possible for you to add a debug icon and create a PR against the branch test_icons ?

@ all: What was the decision, which icons we use? Does Android documentation have a recommendation in this regard? Ones with padding or without?

Strubbl avatar Mar 11 '18 09:03 Strubbl

@Strubbl, I've provided a debug icon at #638. Will that PR not suffice? I will gladly make one against the branch you mentioned if that is the case.

Information regarding padding for product icons can be found here: Material Design Guidelines.

The relevant information is in the section titled "DP unit grid". I am not sure I understood it though so it would be nice if someone could go through it and explain what exactly it is saying. Also, there is mention of padding in the document regarding Implementing Adaptive Icons. The content I am talking about is at the very end of the page, in the "Known Issues" section. Does that apply to us and even if it doesn't presently, is it something we should be taking into consideration when it comes to padding?

lokesh-krishna avatar Mar 13 '18 16:03 lokesh-krishna

I prefer without padding, but it's only my opinion.

ngosang avatar Mar 24 '18 14:03 ngosang

Seeing how we could go with either, opinions are all that matter. Would love to somehow see what the consensus and merge one of them.

lokesh-krishna avatar Apr 07 '18 12:04 lokesh-krishna

are we waiting for something?

ngosang avatar Jun 06 '19 18:06 ngosang

I prefer the one without padding, which should integrate more easily in a multitude of launchers and custom icons pack. But I agree that either way this should be merged 😄

techexo avatar Aug 26 '19 13:08 techexo