android-app icon indicating copy to clipboard operation
android-app copied to clipboard
verified publisher icon wallabag

Autohide toolbar on scroll

Open nvllz opened this issue 11 months ago • 2 comments

This PR aims to improve reading experience as well as add a modern touch while not breaking a thing.

https://github.com/user-attachments/assets/6454b73a-114b-425d-9209-c67a49877d9f

  • replaced actionbar with toolbar on article screen and made it collapse/show on scroll
  • preserving current fullscreen mode state (hide article toolbar)
  • collapse the mainactivity toolbar on scroll and automatically show it with onResume
  • improved status bar coloring consistency – match toolbar (primarycolor) to make the collapsed state more appealing
  • tested with all themes, as I didn't want to break anything
  • fixed some deprecated values (sp, fill_parent)

Closes https://github.com/wallabag/android-app/issues/1215 https://github.com/wallabag/android-app/issues/114 https://github.com/wallabag/android-app/issues/442

nvllz avatar Mar 26 '25 09:03 nvllz

Thank you very much for sharing these changes. I also saw issues with the app when we compile against target SDK 35. Maybe these issues are also fixed by your change. I'll try to review this PR soon.

Strubbl avatar Jun 04 '25 19:06 Strubbl

looks great.

tahr35 avatar Jun 09 '25 22:06 tahr35

i rebased my PR #1468 on your changes and i think for target SDK 35 this needs some rework. The top bar does not fully hide. Can you support in resolving the problems with the new SDK?

Strubbl avatar Jul 01 '25 19:07 Strubbl