workerman icon indicating copy to clipboard operation
workerman copied to clipboard
verified publisher icon walkor

Add PHP 8.4 nightly to tests

Open joanhey opened this issue 1 year ago • 3 comments

So we can find problems with time.

PHP 8.4 Timetable https://wiki.php.net/todo/php84

WIP

joanhey avatar Aug 08 '24 10:08 joanhey

Pest still don't work with PHP 8.4 https://github.com/pestphp/pest/issues/1199

And more packages have problems with the explicit nullable type from PHP 8.4 https://github.com/composer/composer/issues/12051

EDIT: Pest is working OK now 19/10/2024 https://github.com/pestphp/pest/issues/1199

joanhey avatar Aug 08 '24 10:08 joanhey

We still have deprecated messages from the Mockery 2 lib. Mockery 1.6 is fixed for PHP 8.4, but we use v2.0.x that it isn't updated for the last 7 months. We need to check the differences and change to v1.6. Or wait if they fix v2.0.x than it is a dev version.

joanhey avatar Oct 19 '24 11:10 joanhey

We have another problem. Workerman v4.1 also have deprecations:

  • explicit nullable type is only fixable with PHP 7.1 and now only require PHP 7.0
  • Constant E_STRICT is deprecated in /home/runner/work/AdapterMan/AdapterMan/vendor/workerman/workerman/Worker.php on line 518

joanhey avatar Oct 19 '24 21:10 joanhey

We have another problem. Workerman v4.1 also have deprecations:

  • explicit nullable type is only fixable with PHP 7.1 and now only require PHP 7.0
  • Constant E_STRICT is deprecated in /home/runner/work/AdapterMan/AdapterMan/vendor/workerman/workerman/Worker.php on line 518

Perhaps we should raise the minimum PHP version for Workerman v4.1 to 8.0.

walkor avatar Oct 21 '24 03:10 walkor

Never for 4.1, but of course for v4.2 We need to change the composer json, and is ready.

joanhey avatar Oct 23 '24 00:10 joanhey