tidycensus icon indicating copy to clipboard operation
tidycensus copied to clipboard

[Feature Request] Add unit tests via the testthat package

Open philiporlando opened this issue 2 years ago • 2 comments

Please correct me if I'm wrong, but it appears that this package has not incorporated any automated unit testing via the testthat package. Are unit tests being performed using a different method within this package? If so, please let me know so I can incorporate them into my development workflow on my forked version of this repo. If not, are there any plans to add unit testing in future releases?

philiporlando avatar Aug 06 '22 18:08 philiporlando

A test suite would be great; @mfherman and I discussed this a while back here: https://github.com/walkerke/tidycensus/issues/83#issuecomment-575857602. If there is anyone in the user community interested in making this contribution to the package, it would be an excellent addition. The big thing to be mindful of is handling the tests with respect to how CRAN tests the package; this presents more of a challenge with API packages.

walkerke avatar Aug 06 '22 22:08 walkerke

Thank you for providing this info. I have some package development experience, but I have not worked with API packages before. Admittedly, incorporating unit tests into tidycensus appears to be a lot more involved than simply embracing a testthat worfklow. That being said, I'll do more research on this topic and if I come up with anything worthwhile then I'll be sure to submit a PR.

philiporlando avatar Aug 07 '22 19:08 philiporlando