Inconsistent arguments for layer/layer_id in Shiny functions

Open mhpob opened this issue 9 months ago • 2 comments

My assumption was that layer ID would be referred to the same way across functions. However:

set_filter, clear_layer, and move_layer refer to layer as layer_id.
set_layout_property, set_paint_property, set_tooltip, and set_source refer to layer as layer.

If this is something that isn't intentional, I'm happy to submit a PR with the names changed to your choice.

Mar 20 '25 20:03 mhpob

Ah, good catch. The challenge of maintaining a huge codebase.

I'm partial to layer_id, I'll get that fixed (or take a PR).

Mar 22 '25 21:03 walkerke

Since it's kind of an API change, would you want those that have layer as an argument to keep it for now -- just add a layer_id arg? Or are you okay with a breaking change?

Mar 22 '25 23:03 mhpob