mapboxapi icon indicating copy to clipboard operation
mapboxapi copied to clipboard

Consider using RcppSimdJson, jsonify, or yyjsonr instead of jsonlite

Open JosiahParry opened this issue 1 year ago • 1 comments

I noticed that you are using jsonlite::fromJSON to parse fairly large results. From personal experience and benchmarks, jsonlite is one of the slowest packages available for this task. If performance is a goal of this package, I would consider exploring the packages RcppSimdJson & yyjsonr for parsing JSON and jsonify for making json. Simply replacing jsonlite with those dependencies can result in a massive speed up of your code.

JosiahParry avatar May 05 '24 12:05 JosiahParry

Appreciate the suggestion! I think that's something to consider if I find the time. We explored that a few months ago (see https://github.com/walkerke/mapboxapi/issues/39) but it led to breakages in the code, so I ended up tabling that for the time being.

walkerke avatar May 05 '24 13:05 walkerke