Waldir Pimenta
Waldir Pimenta
Note that the changes to `src/block.ts` in this PR are indented with tabs, whereas the rest of the file is indented with spaces.
> is anyone really taking PRs? I kind of put it out there just for documentation for me, lol. Seems petite-vue has been abandoned (due to its 'completeness' and wanting...
> Remove special and invisible characters first I think replacing such characters with hyphens might be more predictable / less surprising. So `#-ask-a-question` is the result I feel would be...
Yeah, I thought that too, but don't know the doc generation pipeline. The only other place this sentence appears, as far as I can tell, is in [Library/Quaternion.cs](https://github.com/mathnet/mathnet-iridium/blob/7911739524677b3582feb713c0a21aa59b0fa119/src/app/MathNet.Iridium/Library/Quaternion.cs#L159), but it...
@cdrnet so how to we move forward here? I suppose even if this is a generated file, there's no harm in merging the PR. If you'd prefer me to proceed...
Yeah, I think that does happen indeed — every now and then I get notifications from GitHub about actions being disabled on forks I had created months earlier to submit...
Looks great! I've left a few minor edit suggestions as inline comments, but other than that, this should be ready to go :)
Btw, what a nice coincidence that you became active precisely during the [Wikimedia Hackathon](https://www.mediawiki.org/wiki/Wikimedia_Hackathon_2024), so I was available to review your changes quickly. I also happened to bump into @WolfgangFahl,...
That looks good, and makes sense. But just to be sure, did you see the inline comment [above](https://github.com/mwclient/mwclient/pull/331#pullrequestreview-2041321849)?
Oh, I must have missed your response somehow — sorry about that. Great, let's go then! LGTM :)