crs-al-language-extension icon indicating copy to clipboard operation
crs-al-language-extension copied to clipboard

Changes in files during renaming

Open FSharpCSharp opened this issue 4 years ago • 9 comments

Question: Why are changes made in the object files when renaming them? Is this really necessary, or could it be omitted?

https://github.com/waldo1001/crs-al-language-extension/blob/4ab6d20f8c792d7072e28b260f4eb98b721e1643/src/WorkspaceFiles.ts#L76

In this line, an adjustment is always made in the files, regardless of the setup. It would be desirable, if this is not absolutely necessary, to be able to switch this on or off by a setting.

FSharpCSharp avatar Sep 21 '20 06:09 FSharpCSharp

Hi,

if you disable all suffix/prefix settings, you should kind of disable this.

what is it that you try to avoid?

waldo1001 avatar Sep 21 '20 06:09 waldo1001

OK, this is basically about any changes in the file. After renaming I have to make corrections manually anyway. Therefore it makes no sense from my personal point of view. So I thought it would be useful to be able to deactivate any changes by an optional setting in the renaming process.

FSharpCSharp avatar Sep 21 '20 06:09 FSharpCSharp

Hi, I am running into the same problem when renaming files with crs-al-language-extension. I need to make adjustments manually after renaming, which is a bit impractical. The option to activate or deactivate by using a setting would be appreciated.

zorngiebel avatar Sep 28 '20 10:09 zorngiebel

Can anyone tell me what kind of adjustments you're talking about?

waldo1001 avatar Oct 05 '20 21:10 waldo1001

Unintentional changes were often made to existing files. However, these changes were only made in the line of code quoted above.

Among the unwanted changes was the automatic addition of prefix / suffix within the object. Sometimes additional quotes were added.

Personally, a switch would be enough for me to activate and deactivate the code line quoted above.

Maybe @zorngiebel could also say something about this. This problem seems to exist with him as well.

FSharpCSharp avatar Oct 07 '20 05:10 FSharpCSharp

My main problems were also automatically added pre-/suffixes and quotes, which made it necessary to manually remove them.

So a switch to deactivate this option would be great.

zorngiebel avatar Oct 13 '20 06:10 zorngiebel

It only sets affixes when you set up to set affixes. So why not just remove the prefix/suffix settings? Sorry, I don't get it. If you don't set up the CRS-settings, it won't do anything .. so now you want to set up the setting, but have an extra setting to not do anything? 🤔

With the quotes, I can see a possible improvement.. but I lach a decent repro-scenario. Do you have an example? Including code and settings, so I can investigate on how to approve?

waldo1001 avatar Oct 13 '20 06:10 waldo1001

Thanks for the answer! If this is really the only thing you do when you make changes to a file here, it should work. The problems just kept coming up, even though I hadn't set up anything with the pre- and suffixes. But okay, I'll try again, and I might come back to it if it still makes changes to files, even if the pre and suffixes are not set up at all.

FSharpCSharp avatar Oct 13 '20 10:10 FSharpCSharp

I'm always interested in the scenario that makes your work worse .. that needs to be fixed ;-).

So if you can give me a repro, I sure will look into it!

waldo1001 avatar Oct 13 '20 10:10 waldo1001