Skynet-IADS icon indicating copy to clipboard operation
Skynet-IADS copied to clipboard

Correction of Harm detection table copy

Open MacFlorent opened this issue 1 year ago • 5 comments

Harm identification is currently only done for the first radar that detects the missile. Later detections by other radars will not try to identify again.

This is because when Skynet evaluates the new radars that should try for identification of the contact, it will compare (in function getNewRadarsThatHaveDetectedContact) :

  • The list [1] of radars currently seeing the contact (contact:getAbstractRadarElementsDetected)
  • The list [2] of radars having already tried to identify it as HARM (self.contactRadarsEvaluated[contact]) And try the identification only for the ones that are in [1] but not in [2]. Then, it will point list [2] to list [1] (to not retry the evaluation for these radars later).

But then, since list [2] points list [1] , each time a radar is added to list [1], it will in effect also be in list [2]. And from now on, there will never be any difference between [1] and [2], and so never any radar with which to try the HARM identification.

Proposed correction is to copy the content of [1] to [2] instead of just pointing to it.

As a sidenote, it seems that the augmented probability when multiple radars are tracking the contact is almost never triggered because it would need the multiple radars to pick up the contact in the same Skynet loop, and this seldom happens in my experience.

MacFlorent avatar Nov 09 '22 16:11 MacFlorent