Why are there no edges between MethodExit nodes and any other nodes?

Open coder-chenzhi opened this issue 6 years ago • 1 comments

I have printed the SDG by GraphPrint.genericToString(). However, I found there are no edges between MethodExit nodes with any other nodes. For comparison, MethodEntry nodes will not only connect to NormalStatement with SSAAbstractInvokeInstruction in caller , but also the first statement of corresponding methods in callee. It is intentionally to leave MethodExit nodes asides, or it is because we forget to add control dependencies for MethodExit nodes in PDG.createControlDependenceEdges() https://github.com/wala/WALA/blob/ddba00a78382534906d9e1014fde9d7129fddf0b/com.ibm.wala.core/src/com/ibm/wala/ipa/slicer/PDG.java#L242-L405

Jun 02 '19 05:06 coder-chenzhi

Honestly I have no idea why the MethodExit nodes are disconnected. Can you see if they get connected if you add control dependencies? If they are still disconnected maybe we can just get rid of them.

Jun 02 '19 16:06 msridhar