Module should implement Closeable

[sewe]

At the moment, there is no way for a Module to be closed properly, in order to release its resources. This is a problem at least for JarFileModule, as the underlying JarFile won’t be closed.

If backward compatibility with existing Module implementations is a concern (not sure if there are that many), a default close() method might be added.

[sewe]

One thing that is IMHO important is that the WALA “framework” does not itself try to close() a Module itself when it thinks it is done with it. Instead, it should be the client’s obligation to do so, as only the client knows when he is done with the analysis. For example, a single Module may be reused by multiple analyses in different AnalysisScopes. Only when the last analysis is done, need the Module be closed.

[liblit]

This is closely related to issue #236, or might even be the same thing.