js-waku icon indicating copy to clipboard operation
js-waku copied to clipboard

allow user to pass content topic to createSubscription

Open adklempner opened this issue 1 year ago • 2 comments

This is a feature or change request

Problem

Currently, creating a subscription via filter requires passing an instance of SingleShardInfo. This is not user friendly when using autosharding. The user should be able to just pass in the content topic in order to create a subscription.

Proposed Solutions

Modify createSubscription to accept a content topic and convert it to the proper pubsubTopic within the function itself.

Notes

Related to #1500

adklempner avatar Dec 19 '23 05:12 adklempner

Related to #1814

chair28980 avatar Jan 31 '24 15:01 chair28980

creating a subscription via filter requires passing an instance of SingleShardInfo

it takes either SingleShardInfo or the type PubsubTopic which is string, which seems to be relevant for autosharding. what am i missing?

danisharora099 avatar Feb 12 '24 08:02 danisharora099