js-waku icon indicating copy to clipboard operation
js-waku copied to clipboard

chore: Filter and Relay should be compliant with `IReceiver`

Open danisharora099 opened this issue 1 year ago • 1 comments

With work on #1682, we are changing the Filter API -- this also impacts the IRelay API as both of these protocol implementations are expected to be compliant with our IReceiver interface.

In the interest of keeping the PR straightforward, only Filter refactor is addressed with #1682.

This issue aims to track the work around Relay, and necessary updates to the IReceiver API.

This was discussed in the PM meeting (https://github.com/waku-org/js-waku/issues/1683#issuecomment-1799056053).

Acceptance Criteria:

  • [ ] update Relay protocol, in a similar structure as Filter
  • [ ] emsure Filter and Relay are compliance with IReceiver (update IReceiver accordingly)
  • [ ] update & ensure these protocol implementations work with toAsyncIterator
    • [ ] un-skip the Util: toAsyncIterator: Filter test

danisharora099 avatar Nov 08 '23 12:11 danisharora099

Depends on #1683

chair28980 avatar Jan 04 '24 16:01 chair28980