js-waku
js-waku copied to clipboard
take steps to avoid/debug breaking circular deps
This is a feature request
Problem
There have been times where circular dependencies have creeped in to our codebase - one of these times was recently with https://github.com/waku-org/js-waku/pull/1520/commits/c421732c09d689070626ec40f2c0711392cb20e8 where the tests were failing because of a circular dependency introduced earlier which was not caught until now.
Proposed Solutions
Introduce a check for circular deps.
I used madge
: https://www.npmjs.com/package/madge to debug
TODO:
- [ ] perhaps add a README to include steps we can take when the build fails for breaking circular deps
- [ ] research codeclimate to see if it can help