go-waku
go-waku copied to clipboard
waku-org
chore: sharding tests update
Description
Batch of tests for Waku sharding functionality to extend existing tests
Changes
Tests available to run: cd go-waku/waku/v2/node go test
Jenkins Builds
Click to see older builds (55)
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | 0e0ff462 | #1 | 2024-03-19 10:19:22 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | bbf74870 | #2 | 2024-03-19 10:21:29 | ~2 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 77468d6b | #3 | 2024-03-20 04:15:07 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | abec5b01 | #4 | 2024-03-20 07:02:23 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | a8689eb7 | #5 | 2024-03-20 09:47:55 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | a3ec2823 | #6 | 2024-03-20 10:01:01 | ~2 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 3fe24f68 | #7 | 2024-03-21 10:39:08 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | c0e44b6a | #8 | 2024-03-21 10:41:24 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 77f1f596 | #9 | 2024-03-21 14:13:51 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 6495860a | #10 | 2024-03-23 05:17:43 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | ff01699e | #11 | 2024-03-23 05:27:28 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 95f3ff0a | #12 | 2024-03-23 05:45:13 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | d26f178c | #13 | 2024-03-23 05:56:32 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 265909a2 | #14 | 2024-03-26 00:03:17 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 54edf8bb | #15 | 2024-03-26 00:28:21 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 5a767738 | #16 | 2024-03-26 06:18:36 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | dc4ed27c | #17 | 2024-03-27 10:15:43 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 4266513a | #18 | 2024-03-28 02:38:51 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | b9e700fe | #19 | 2024-04-01 10:45:46 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | c15768b8 | #20 | 2024-04-01 10:49:07 | ~3 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 2c66e916 | #21 | 2024-04-02 07:12:42 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 4e89a8fc | #22 | 2024-04-02 07:19:49 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | def82f2a | #23 | 2024-04-02 07:24:52 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 3b571baf | #24 | 2024-04-02 07:26:49 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | c80456dd | #25 | 2024-04-02 11:14:07 | ~2 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 873caa8a | #26 | 2024-04-03 11:10:49 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 502ff9d4 | #27 | 2024-04-04 05:55:26 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 72be4834 | #28 | 2024-04-04 23:48:34 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 9693bedc | #29 | 2024-04-08 02:26:33 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | b6fc2cb6 | #30 | 2024-04-08 02:32:49 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 5de4bfac | #31 | 2024-04-08 11:06:39 | ~6 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 8efec1ef | #32 | 2024-04-08 11:11:17 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 1cd52ee6 | #33 | 2024-04-10 12:49:34 | ~7 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 891d9a9f | #34 | 2024-04-10 12:53:53 | ~4 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | d27c0ed1 | #35 | 2024-04-10 13:01:57 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | e1210c7c | #36 | 2024-04-10 13:15:42 | ~2 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | b562771c | #37 | 2024-04-11 02:12:40 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 8d7e31bd | #38 | 2024-04-15 06:29:43 | ~1 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 99e3f334 | #39 | 2024-04-22 02:52:46 | ~5 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | adaace39 | #40 | 2024-04-22 02:55:47 | ~2 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 590e4ffa | #41 | 2024-04-23 02:36:14 | ~2 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 7404bb41 | #42 | 2024-05-02 02:29:00 | ~2 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 12a8923d | #43 | 2024-05-02 07:26:37 | ~2 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 73a90e08 | #44 | 2024-05-02 09:33:43 | ~2 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | fa01d173 | #45 | 2024-05-02 11:05:39 | ~2 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 093ea363 | #46 | 2024-05-02 11:21:38 | ~2 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | dd960ef9 | #47 | 2024-05-03 06:44:41 | ~2 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 2d0af554 | #48 | 2024-05-03 10:02:35 | ~2 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 77f6917f | #49 | 2024-05-03 11:02:20 | ~2 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 6a72e6d8 | #50 | 2024-05-03 11:14:15 | ~2 min | nix-flake |
:page_facing_up:log |
| :heavy_multiplication_x: | 1afb587c | #51 | 2024-05-03 11:27:49 | ~14 sec | nix-flake |
:page_facing_up:log |
| :heavy_multiplication_x: | 3a1a7e6c | #52 | 2024-05-03 11:30:27 | ~16 sec | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 0741101a | #53 | 2024-05-03 11:41:00 | ~2 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | 8968e593 | #54 | 2024-05-03 11:55:11 | ~2 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | a047dd8d | #55 | 2024-05-03 11:57:54 | ~2 min | nix-flake |
:page_facing_up:log |
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | 01803ded | #56 | 2024-05-03 12:01:21 | ~2 min | nix-flake |
:page_facing_up:log |
| :heavy_check_mark: | a369fa40 | #57 | 2024-05-04 01:22:36 | ~2 min | nix-flake |
:page_facing_up:log |
I've reverted "TestStaticShardingLimits" to its desired form and marked it as flaky. This way we can unblock this PR and start a collection of flaky tests. Flaky test could take a time to resolve, sometimes it could lead to a design change. There is still some value to keep them. What are your thoughts ? @chaitanyaprem @richard-ramos I suggest skip mechanism for those tests would be:
if os.Getenv("RUN_FLAKY_TESTS") != "true" {
log.Info("Skipping", zap.String("test", t.Name()),
zap.String("reason", "RUN_FLAKY_TESTS environment variable is not set to true"))
t.SkipNow()
}
@romanzac CI seems to be failing, we will have to fix that.
One more comment and once both of these are fixed, we can merge .
@romanzac CI seems to be failing, we will have to fix that.
One more comment and once both of these are fixed, we can merge .
CI if failing at Go installation step. I saw https://github.com/waku-org/go-waku/pull/1091 upgrades Go version. Could you please check for me value of ${{ needs.env.outputs.go_version }} in repo settings or give me access so I can see the value ?
@romanzac CI seems to be failing, we will have to fix that. One more comment and once both of these are fixed, we can merge .
CI if failing at Go installation step. I saw #1091 upgrades Go version. Could you please check for me value of ${{ needs.env.outputs.go_version }} in repo settings or give me access so I can see the value ?
Hmm, that is not yet merged. Also, wondering why it is failing for this PR only?
Also, i don't see any such setting in repo settings->environment. Is that the place to look?
Can be merged once CI is fixed.
I've contacted Richard few hours ago. I'll try few things before he responds.
CI will fail for mac os on other open PRs as well https://github.com/waku-org/go-waku/actions/runs/8695926246/job/24553205881
Ubuntu builds without any problem.
Why is this branch showing soo much diff with master? Let us not merge when diff is like this..it means the git tree is probably messed up. Ideally, we should rebase from master, pass CI and then merge it.
Hopefully nothing got messed up.
Why is this branch showing soo much diff with master? Let us not merge when diff is like this..it means the git tree is probably messed up. Ideally, we should rebase from master, pass CI and then merge it.
Hopefully nothing got messed up.
This is what I have done. Rebased from master, passed CI and then merged. No worries.
Why is this branch showing soo much diff with master? Let us not merge when diff is like this..it means the git tree is probably messed up. Ideally, we should rebase from master, pass CI and then merge it.
Hopefully nothing got messed up.
This is what I have done. Rebased from master, passed CI and then merged. No worries.
Oh, interesting...in that case the diff shouldn't be this big right
Why is this branch showing soo much diff with master? Let us not merge when diff is like this..it means the git tree is probably messed up. Ideally, we should rebase from master, pass CI and then merge it. Hopefully nothing got messed up.
This is what I have done. Rebased from master, passed CI and then merged. No worries.
Oh, interesting...in that case the diff shouldn't be this big right
I remember I've done merge at some point too. What is interesting, the final merge into master has normal (expected) diff https://github.com/waku-org/go-waku/commit/a453c027b71cbf8d1b01d009e769d1b7d0faa8b5 My IDE also shows the same.
Should we be fine ? @chaitanyaprem