homebridge-sensibo-sky icon indicating copy to clipboard operation
homebridge-sensibo-sky copied to clipboard

Siri doesn't change the temperature

Open cohenjonathan opened this issue 6 years ago • 9 comments

When asking siri to change the temperatue, it's only do the following: [7/8/2018, 11:22:55 AM] [Sensibo] Living room : Setting threshold (name: Living room , threshold: 22 )

When changing Manually using homekit it does the following: [7/8/2018, 11:22:48 AM] [Sensibo] Living room State change set, current ACstate: cool new state: 2 [7/8/2018, 11:22:48 AM] [Sensibo] Living room - Submit state change: New state: cool On/Off Status: true [7/8/2018, 11:22:49 AM] [Sensibo] Changed status (name: Living room , roomTemp: 25, on: true, mode: cool, targetTemp: 21, speed: auto)

It seems like Siri only sets a threshold instead of changing the status. Is that in any way related to the name of the accessory?

Thanks!

cohenjonathan avatar Jul 08 '18 15:07 cohenjonathan

Do you happen to be on iOS12? Maybe its server side but turning the ac on broke since I updated, I think Siri is changing the rotation service even though home app doesnt even see it (inside the thermostat)

Sent from my iPhone

On Jul 8, 2018, at 11:31 AM, JohnnatanCohen [email protected] wrote:

When asking siri to change the temperatue, it's only do the following: [7/8/2018, 11:22:55 AM] [Sensibo] Living room : Setting threshold (name: Living room , threshold: 22 )

When changing Manually using homekit it does the following: [7/8/2018, 11:22:48 AM] [Sensibo] Living room State change set, current ACstate: cool new state: 2 [7/8/2018, 11:22:48 AM] [Sensibo] Living room - Submit state change: New state: cool On/Off Status: true [7/8/2018, 11:22:49 AM] [Sensibo] Changed status (name: Living room , roomTemp: 25, on: true, mode: cool, targetTemp: 21, speed: auto)

It seems like Siri only sets a threshold instead of changing the status. Is that in any way related to the name of the accessory?

Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Cloudore avatar Jul 08 '18 21:07 Cloudore

Hey, Not using IOS 12, and as i said, On/Off worked just perfectly fine, so i don't think its realted to how Siri work internaly/remotely.

I did find a workaround with a code edit. I noticed that when changing with Siri, it changes the threshold and thats it:

// Cooling Threshold Temperature Characteristic
	this.getService(Service.Thermostat)
		.getCharacteristic(Characteristic.CoolingThresholdTemperature)
		.on("get", function(callback) {
			callback(null, that.coolingThresholdTemperature);
		})
		.on("set", function(value, callback) {
			callback();
			that.log(that.name,": Setting TThreshold (name: ",that.name,", threshold: ",value,")");
			that.coolingThresholdTemperature = value;
			//that.coolingThresholdTemperature = that.temp.temperature;
		});

I Ended by inserting the folowing line: that.getService(Service.Thermostat).getCharacteristic(Characteristic.TargetTemperature).setValue(value, callback);

and off course removing the callback.

So evantually:

	// Cooling Threshold Temperature Characteristic
	this.getService(Service.Thermostat)
		.getCharacteristic(Characteristic.CoolingThresholdTemperature)
		.on("get", function(callback) {
			callback(null, that.coolingThresholdTemperature);
		})
		.on("set", function(value, callback) {
			that.log(that.name,": Setting TThreshold (name: ",that.name,", threshold: ",value,")");
			that.coolingThresholdTemperature = value;
			that.getService(Service.Thermostat).getCharacteristic(Characteristic.TargetTemperature).setValue(value, callback);
			//that.coolingThresholdTemperature = that.temp.temperature;
		});

Works perfectly fine, It would be great if the creator(@wailuen ) can spill some light on it.

Many thanks! :)

cohenjonathan avatar Jul 09 '18 15:07 cohenjonathan

@JohnnatanCohen Can you please submit a Pull Request with your fix for this issue?

leoneleone avatar Sep 15 '18 00:09 leoneleone

@JohnnatanCohen I second @leoneleone - I also lost the ability to alter temperature through Siri, and would very much like to regain it. Alternatively, if anyone could point me to directions for modifying the code I would be happy to give that a try.

jsundgot avatar Oct 19 '18 20:10 jsundgot

@JohnnatanCohen I third @leoneleone - Same situation, no temperature control through siri... through homekit manully works fine though...

JoshKitson avatar Nov 05 '18 04:11 JoshKitson

@JohnnatanCohen Thanks that got Siri control of setpoint working for me. I don't understand the changes but I will test and see if any other problems arise for me.

DarylMc avatar Nov 13 '18 04:11 DarylMc

@JohnnatanCohen

Where do I need to place this code?

ekatsili avatar Nov 24 '18 03:11 ekatsili

you can find it in /usr/lib/node_modules/homebridge-sensibo-sky-7modes/accessories/pods.js

shereefalkady avatar Jun 22 '19 14:06 shereefalkady

Pr #36 implements this code

imerin avatar Jul 17 '19 13:07 imerin