wails icon indicating copy to clipboard operation
wails copied to clipboard

<video/> tag can not be full screen

Open ghost opened this issue 3 years ago • 11 comments

Description

'https://github.com/webview/webview/' Use the repository to display full-screen buttons for full-screen video playback


But the same code use wails Can not play full screen

To Reproduce

vue3 html

<video controls width="500" >
        <source
          src="https://interactive-examples.mdn.mozilla.net/media/cc0-videos/flower.webm"
          type="video/webm"
        />
        <source
          src="https://interactive-examples.mdn.mozilla.net/media/cc0-videos/flower.mp4"
          type="video/mp4"
        />
      </video>

Expected behaviour

The full-screen button should be displayed for full-screen playback

Screenshots

No response

Attempted Fixes

No response

System Details

------
OS:		MacOS
Version: 	12.3.1
ID:		21E258
Go Version:	go1.18.5
Platform:	darwin
Architecture:	amd64

Wails
------
Version: 	v2.1.0

Additional context

No response

ghost avatar Nov 16 '22 10:11 ghost

Hi 👋 Why are you referencing 'https://github.com/webview/webview/'?

leaanthony avatar Nov 17 '22 09:11 leaanthony

@leaanthony hi Because I suspect a browser kernel problem。

webview This is just an example. It uses the webkit kernel, which renders <video /> perfectly and supports full-screen playback.

but wails webkit kernel, <video /> Full screen playback, it doesn't work

ghost avatar Nov 18 '22 03:11 ghost

AFAIK they use the same engine: WkWebView. Are you able to provide a project showing this?

leaanthony avatar Nov 25 '22 03:11 leaanthony

Any update on this?, I want to make a video go full screen but unable to do it.

kxnakr avatar May 22 '23 10:05 kxnakr

@krishna8421 Please can you retry using the latest version. Remember to upgrade the version of Wails in you project's go.mod.

leaanthony avatar May 25 '23 08:05 leaanthony

@leaanthony Hey updated to v2.5.1, full screen working on the browser but not in the app. can you give some example codes or reference how to do it, maybe I am doing something wrong.

kxnakr avatar May 25 '23 17:05 kxnakr

im facing same issue too. i tried in linux and windows, in linux, video switches to fullscreen mode as it should. in windows, full screen mode is the size of the open window and is not truly full screen.

marifcelik avatar Jul 25 '23 15:07 marifcelik

@leaanthony I'm wondering if allowing to set elementFullscreenEnabled in the preferences on mac won't address the issue. I'll check

fkhadra avatar Sep 24 '23 13:09 fkhadra

So just tested and it seems to work as expected :).

https://github.com/wailsapp/wails/assets/5574267/eb338fe3-437f-4f9f-9155-14d12145a7ba

fkhadra avatar Sep 24 '23 13:09 fkhadra

@fkhadra the situation with windows is a lot worse: https://github.com/MicrosoftEdge/WebView2Feedback/issues/1834

leaanthony avatar Oct 22 '23 10:10 leaanthony

I'm not sure why, but this works really well on Windows in v3....

leaanthony avatar Oct 23 '23 09:10 leaanthony