GoOracle icon indicating copy to clipboard operation
GoOracle copied to clipboard

Windows support?

Open liuhewei opened this issue 10 years ago • 2 comments

Hi,

It seems that GoOracle doesn't support windows platform. It works well on my Macbook, but when I'm using it on my windows machine (win7), errors prompted:

  • "UnicodeDecodeError: 'utf-8' codec can't decode byte 0xb2 in position 9: invalid start byte" on https://github.com/waigani/GoOracle/blob/master/goOracle.py#L126: It seems the stdout/stderr message is not encoded in "utf-8". I checked with 'print sys.stdout.encoding', and found it's "cp936". I set the environment variable "PYTHONIOENCODEING" to "utf-8" but seems it's useless for Sublimetext.
  • Then I went to the "cmd" here: https://github.com/waigani/GoOracle/blob/master/goOracle.py#L107 Obviously, it's not for windows...

Do you plan to support Windows platform? For myself, my working environment is mainly windows...

liuhewei avatar Nov 18 '14 13:11 liuhewei

Interesting. Unfortunately I don't have Windows, which makes it hard to debug. You've defined the bug well. I'd encourage you to fork the code and experiment. If you find a solution, please make a pull request .

waigani avatar Nov 24 '14 07:11 waigani

@waigani Yes. I chose some time today to give it a try for windows support, and submitted a PR finally. It works well on my environment. Hope it could help other guys working under Windows.

liuhewei avatar Nov 25 '14 10:11 liuhewei