wagtailtrans icon indicating copy to clipboard operation
wagtailtrans copied to clipboard

Published 20 hours ago • verified publisher icon wagtail

Translatable mixin

Open kaedroho opened this issue 6 years ago • 8 comments

https://github.com/wagtail/wagtailtrans/issues/152

This PR adds a TranslatableMixin as described in #152.

TODO:

  • [x] Replacement for Language.has_pages_in_site
  • [ ] Docs

kaedroho avatar Feb 18 '19 15:02 kaedroho

Hi @kaedroho

Awesome! This is something I've wanted for a while now, especially to translate content other than pages. Think we should handle this carefully for the Pages part, since querying on TranslatablePage is used a lot in wagtailtrans..

mikedingjan avatar Feb 21 '19 13:02 mikedingjan

Can I help move this along? We have an existing project with a lot of models that I'd like to add wagtailtrans to and I like this approach!

All the tests are passing.

mihow avatar Jun 21 '19 17:06 mihow

Hi @mihow, I would also like to move this along! in the todo's there is a mention about the docs that need updating, maybe you can help with that?

mikedingjan avatar Jul 31 '19 18:07 mikedingjan

for the rest it needs testing, also for existing installations.. I will see if I can make some time to do that as well..

mikedingjan avatar Jul 31 '19 18:07 mikedingjan

Hee @mikedingjan 😄

This PR looks promising, especially with the possibility for snippet translations as well. Would be an extra reason to use wagtailtrans in a project.

A scan trough the code implies to me that you can use this PR "as is" without any issues in an existing installation right?

What kind of documentation is needed? As far as I can see only the mention of that a TranslatableMixin which can be used to translate snippets or other things as well, and a release note?

maerteijn avatar Aug 27 '19 11:08 maerteijn

Hi @maerteijn ,

This is true, we're using it in a project already and works good. However, merging without the documentation isn't something I like to do, it's simply not finished yet and postponing something like this is (in most cases) something that doesn't happen at all..

It surely is something I wanted for wagtailtrans since the beginning, but don't have the time to finish it, also the original author seems to have abandoned this PR, so I'm looking for someone who wants to make this last stretch.

mikedingjan avatar Aug 30 '19 18:08 mikedingjan

I understand. Could you explain what you expect for documentation and I’ll see what I can do!

maerteijn avatar Aug 31 '19 09:08 maerteijn

I think some explanation about how to use the mixin and maybe validate if the rest of the docs are still valid (I think so though)..

mikedingjan avatar Sep 02 '19 14:09 mikedingjan