wagtail icon indicating copy to clipboard operation
wagtail copied to clipboard

Published 20 hours ago • verified publisher icon wagtail

option for assertCanCreateAt to check for saving draft pages

Open hjwp opened this issue 6 years ago • 2 comments

this is something i wanted in my own project, was quite a simple hack to change the helper test utils, thought i'd see if y'all were interested.
WIP!

  • [ ] Do the tests still pass? (http://docs.wagtail.io/en/latest/contributing/developing.html#testing)
  • [ ] Does the code comply with the style guide? (Run make lint from the Wagtail root)
  • [ ] For Python changes: Have you added tests to cover the new/fixed behaviour?
  • [x] For front-end changes: Did you test on all of Wagtail’s supported browsers? Please list the exact versions you tested.
  • [ ] For new features: Has the documentation been updated accordingly?

hjwp avatar Aug 29 '18 13:08 hjwp

Thanks @hjwp - yep, would be interested in including this!

gasman avatar Sep 05 '18 15:09 gasman

@hjwp would you mind me working on the documentation for this pull request?

DokuaAsiedu avatar Oct 18 '22 11:10 DokuaAsiedu

@lb- I have not gotten a response from the author yet. I'm going on to edit the docs for this then?

DokuaAsiedu avatar Oct 21 '22 08:10 DokuaAsiedu

New PR that may potentially supercede this one.

https://github.com/wagtail/wagtail/pull/9458

lb- avatar Oct 22 '22 00:10 lb-

@hjwp thanks for this PR (many years ago), it has now been merged with some clean up, unit tests & docs added via #9458

@DokuaAsiedu - thanks for your epic work on this.

lb- avatar Oct 26 '22 21:10 lb-

@hjwp thanks for this PR (many years ago), it has now been merged with some clean up, unit tests & docs added via #9458

@DokuaAsiedu - thanks for your epic work on this.

Thanks @lb- and thanks @hjwp for your contribution

DokuaAsiedu avatar Oct 27 '22 19:10 DokuaAsiedu