wagtail icon indicating copy to clipboard operation
wagtail copied to clipboard

Add show password functionality for the login page #11948

Open riaan-attar opened this issue 1 year ago • 3 comments

In this Login page i had added the functionality to show password using JS issue number #11948

riaan-attar avatar May 19 '24 09:05 riaan-attar

Manage this branch in Squash

Test this branch here: https://riaan-attarpatch-1-aktvt.squash.io

squash-labs[bot] avatar May 19 '24 09:05 squash-labs[bot]

Thanks @riaan-attar - we are currently in the process of removing inline scripts as they can cause issues with CSP compliance.

I'd recommend you have a read of our section that talks about Stimulus as our preferred library for making small user interactions.

https://docs.wagtail.org/en/stable/contributing/ui_guidelines.html#stimulus

I'd suggest you maybe look at enhancing the ActionController to support the field conversion and then go from there.

lb- avatar May 20 '24 20:05 lb-

@riaan-attar are you still interested in pursuing this pull request?

If not we will probably close this in a few weeks.

lb- avatar Oct 02 '24 05:10 lb-

Closing this PR as there has not been a response.

A recommended approach with links to example code has been added to the issue https://github.com/wagtail/wagtail/issues/11948#issuecomment-2148223859

lb- avatar Oct 24 '24 21:10 lb-