wagtail-personalisation icon indicating copy to clipboard operation
wagtail-personalisation copied to clipboard

Should date / time rules be timezone-aware?

Open tomdyson opened this issue 8 years ago • 1 comments
trafficstars

The date and time rules are currently based on the server's clock:

https://github.com/LabD/wagtail-personalisation/blob/master/src/wagtail_personalisation/rules.py#L77

In some (most?) cases it will be more useful to base time rules on the user's clock, e.g. using the time rule to say 'Good morning' when the user is in Delhi and the server is in Cape Town.

In any case, the behaviour should be clarified for segment creators.

tomdyson avatar May 31 '17 13:05 tomdyson

Nice found. Will fix it.

robmoorman avatar May 31 '17 13:05 robmoorman