sphinx-wagtail-theme icon indicating copy to clipboard operation
sphinx-wagtail-theme copied to clipboard

Published 20 hours ago • verified publisher icon wagtail

Upgrade Bootstrap to version 5

Open lb- opened this issue 1 year ago • 4 comments

Currently the Theme is using Bootstrap 4 and it would be good to upgrade to version 5.

Split from #252 / #250

Bootstrap 5 did remove jquery as a dependency. Not sure how broken that would be to upgrade, or if it would be a mostly drop-in replacement given our minimal bootstrap usage. https://getbootstrap.com/docs/5.2/migration/ Originally posted by @vsalvino in https://github.com/wagtail/sphinx_wagtail_theme/issues/252#issuecomment-1460813826

It may be worth considering a small clean up of unused styles in the process. See https://github.com/wagtail/sphinx_wagtail_theme/issues/64

lb- avatar Mar 11 '23 00:03 lb-

it used Bootstrap CDN ??

dassudip2001 avatar Mar 12 '23 13:03 dassudip2001

It's a front-end dependency see https://github.com/wagtail/sphinx_wagtail_theme/blob/main/package.json#L23

lb- avatar Mar 12 '23 19:03 lb-

Screenshot from 2023-03-13 09-44-18

i can fix it ? can i send a PR

dassudip2001 avatar Mar 13 '23 04:03 dassudip2001

Just a thought. Is it worth looking at something more lightweight instead of Bootstrap.

Maybe too lightweight - https://open-props.style/ - but super flexible with CSS Custom Properties as the core method of designs.

Not sure on other options, maybe we need to review the actual Bootstrap parts used.

Also need to consider the ability to customise and override things for others.

lb- avatar Mar 10 '24 05:03 lb-