docker-wagtail-develop icon indicating copy to clipboard operation
docker-wagtail-develop copied to clipboard

Add Willow and django-modelcluster as locally editable dependencies

Open saevarom opened this issue 5 years ago • 4 comments

saevarom avatar Jan 29 '20 13:01 saevarom

Willow has been added in commit 7ba9d32408e368846ddd7c7e79835d8f5b158e9b

saevarom avatar Jun 20 '22 11:06 saevarom

I use this with a few other libraries so my Dockerfile looks like:

#...

COPY ./wagtail /code/wagtail/
COPY ./libs /code/libs/

RUN cd /code/wagtail/ \
     && pip install -e .[testing,docs]

RUN cd /code/libs/ \
    && pip install -e wagtail-headless-preview wagtail-localize wagtail-markdown wagtailmedia Willow

# ...

I wonder if there's scope to install everything in /code/libs/ so then anything in there can be picked up automatically without having to edit the Dockerfile

zerolab avatar Jun 20 '22 13:06 zerolab

Yes, I think we should definitely figure out a way to pip install everything in /code/libs. Probably just a matter of doing some clever shell magic to list the folder names after pip install -e

saevarom avatar Jun 20 '22 13:06 saevarom

I've create a PR which should theoretically allow you to put local versions of dependencies into the libs folder and then the Dockerfile will pick it up and local pip install it. Would be nice if you could try it out some time @zerolab .

saevarom avatar Jun 20 '22 20:06 saevarom