dive icon indicating copy to clipboard operation
dive copied to clipboard

Layers pane doesn't scroll when navigating to layer below visible region

Open matt-winfield opened this issue 2 years ago • 12 comments
trafficstars

What happened: When viewing an image with more layers than can fit in the "layers" pane, when navigating down to a layer not visible, the pane does not scroll to show it. PageUp / PageDown keys also do not scroll the pane.

What you expected to happen: The pane should scroll to keep the currently selected layer visible

How to reproduce it (as minimally and precisely as possible): Open an image with enough layers to not fit into the pane Navigate down until you go beyond the visible layers.

Environment:

  • OS version - Windows 10 Pro, 22H2, 19045.3324
  • Powershell and Command Prompt, Windows Terminal
  • Docker version - 20.10.16

matt-winfield avatar Aug 13 '23 09:08 matt-winfield

See comment.

I have something in progress, but it's not ready yet, hopefully soon.

mark2185 avatar Aug 13 '23 10:08 mark2185

Screenshot_20230820_181418 Layer Details is missing layer size. Which makes not accessible info beyond navigating list. Will be nice adding layer size into Layer Details :smile:

dd84ai avatar Aug 20 '23 16:08 dd84ai

TIP: This is a pretty limiting bug and older versions are not available on macOS brew. To workaround it try:

docker run -ti -v /var/run/docker.sock:/var/run/docker.sock wagoodman/dive:v0.10.0 IMAGE:TAG

Btw it doesn't show the full command line though of each RUN so that limits usefulness if you use --build-arg's.

jamshid avatar Sep 03 '23 17:09 jamshid

Could you please give #473 a spin to see if it works well enough?

mark2185 avatar Sep 06 '23 20:09 mark2185

@mark2185 I've built your branch on Ubuntu 22.04 after having the scrolling bug with v0.11.0, and the bug still happens on your PR branch, built with golang 1.21 :(

graffight avatar Sep 11 '23 09:09 graffight

Any update on this ? I have quiet a lot of layers in my image :(

perryrh0dan avatar Sep 25 '23 09:09 perryrh0dan

I just submitted a fix that works for me #478

moaimullet avatar Sep 27 '23 18:09 moaimullet

@dd84ai: I added the size information to the layer details view (PR 522) I also added scrolling in the layers view see (PR 521)

st-gr avatar May 10 '24 10:05 st-gr