salesforce-cli-zsh-completion icon indicating copy to clipboard operation
salesforce-cli-zsh-completion copied to clipboard

add to oh-my-zsh

Open ChuckJonas opened this issue 7 years ago • 8 comments

This is awesome. Not sure what it takes to get it added, but I'd love to see this included in the default OhMyZsh plugin list

https://github.com/robbyrussell/oh-my-zsh/tree/master/plugins

ChuckJonas avatar Aug 03 '18 17:08 ChuckJonas

Adding it to zsh-users/zsh-completions would make it available in antigen, oh-my-zsh and prezto.

See their contribution guidelines.

@wadewegner ...would you consider adding _sfdx to the project?

catalandres avatar Aug 15 '18 14:08 catalandres

I'm pretty sure I sent PRs to both of these and they were never accepted.

wadewegner avatar Aug 15 '18 15:08 wadewegner

oh-my-zsh: https://github.com/robbyrussell/oh-my-zsh/pull/6540

zsh-completions: https://github.com/zsh-users/zsh-completions/pull/550

If you have thoughts on how to get them to accept, I'd be happy to update and send along.

wadewegner avatar Aug 15 '18 15:08 wadewegner

@wadewegner Hi! Just checked on the status of these.zsh-completions has accepted your pull request. oh-my-zsh has two comments before accepting your pull request.

tekamoment avatar Apr 09 '19 05:04 tekamoment

@wadewegner did you ever get this finished?

rsoesemann avatar Apr 14 '19 12:04 rsoesemann

It was merged, but it actually doesn't seem working. I tried adding the plugin to my .zshrc, but no completions appeared

nchursin avatar Aug 03 '19 08:08 nchursin

@nchursin try resetting completions, that did the trick for me:

rm ~/.zcompdump*
compinit

daeschwed avatar Aug 08 '19 11:08 daeschwed

I'm adding this repo to the awesome-zsh-plugins in https://github.com/unixorn/awesome-zsh-plugins/pull/828.

As far as I can tell, upstream oh-my-zsh isn't taking new plugins or themes for the main repo. Standalone git repositories like this make it much easier for people using other frameworks though, so overall that feels like a win.

unixorn avatar Nov 17 '19 16:11 unixorn