change function_name/1 to function(x)

[Freed-Wu]

1. How about change the label of path/1 to path(a) like:

2. Can we have a function signature like clangd for path(?

3. some variable like $JQ_BUILD_CONFIGURATION doesn't exist in gojq. Should they be added manually?

[wader]

1. How about change the label of path/1 to path(a) like:

That should be possible and i'm a bit surprised i didn't already do it, wonder if there was some issue? ill have a look

2. Can we have a function signature like clangd for path(?

Show signature and documentation? with jq-lsp and vscode this is already possible using "textDocument/hover" but maybe other editors want something else?

or do i misunderstand the issue?

3. some variable like $JQ_BUILD_CONFIGURATION doesn't exist in gojq. Should they be added manually?

Yeap i've just forgot to add them, they can be added to https://github.com/wader/jq-lsp/blob/master/lsp/builtin_env.jq, for the most part the file is generated using this mess https://github.com/wader/jq-lsp/blob/master/lsp/gen_builtin_env.jq and i wonder if there is some way to find all globals automatically? 🤔

[Freed-Wu]

Show signature and documentation

It should be signature help? https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_signatureHelp

[wader]

Show signature and documentation

It should be signature help? https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_signatureHelp

Thanks, yeap! i did a quick hack and can get vscode to send textDocument/signatureHelp on ( but there is some problems with how jq-lsp works atm, for example func() is not valid jq so parsing fails, need to do some pre-massaging of the source 🤔 also noticed that you keep getting signature help calls when moving the cursor amoung the args, not sure how that can supported, maybe simplest possible for now.

[wader]

@Freed-Wu signature helper kind of works but i can't figure out how communicate via LSP that a completion should "switch" over to signature help. Ex: you write "gsu" and complete it o "gsub()" no signature help is shown, but if you write "gsub(" it will work. gopls seems to be able to do this but i'm not sure if it's done entirely thru LSP or with help from the client somehow. A completion item can have a command thingy but not sure that is the correct way and also it does not seem to work well.