QMidi icon indicating copy to clipboard operation
QMidi copied to clipboard

Unnecessary disposing

Open Trebor-Huang opened this issue 3 years ago • 1 comments

https://github.com/waddlesplash/QMidi/blob/de0a2b1b3ccc494114353d3eee863bebd6811618/src/OS/QMidi_CoreMidi.cpp#L92-L100

Quoting documentation:

Don’t explicitly dispose of your client; the system automatically disposes all clients when an app terminates. However, if you call this method to dispose the last or only client owned by an app, the MIDI server may exit if there are no other clients remaining in the system. If this occurs, all subsequent calls by your app to MIDIClientCreate and MIDIClientCreateWithBlock fail.

Trebor-Huang avatar Sep 06 '22 13:09 Trebor-Huang

There is also a deprecated API in use. I'm a bit tight on time finishing schoolwork, but after a few days I may come back with a PR.

Trebor-Huang avatar Sep 06 '22 14:09 Trebor-Huang