Andrew Cunningham
Andrew Cunningham
Huh. I don't see any meaningful difference between that and the default function. Are you changing anything else?
A couple problems I see. You generally can't get away with using the default discard function when you use a custom effect reconciler. See [Customize how requests are made](https://github.com/redux-offline/redux-offline/blob/develop/docs/recipes/customize-requests.md). The...
This is a breaking change, obviously. If you wanted to include as is, the modified test should be removed. It is misleading with the included change. Maybe `createOffline` should not...
@bausmeier Good point. Having it as a config option is a better way of doing it. That's how everything else works anyways. And the `createOfline` and `offline` configs differing a...
~Am able to confirm.~ Unfortunately only through an actual application and not with integration tests that should capture the whole process. Time to do some digging... It is currently broken...
Oops, forgot I had overridden the default effect reconciler. The last published version of `@redux-offline/redux-offline` is working for me after all. Guess I'm going to need more information. Which version...
Could you provide some code reproducing the issue? I added an [example app](/redux-offline/redux-offline/tree/example) if you need a starting point.
This was intentional. If fetch fails to communicate with the server at all, maybe the user is offline, fetch will reject with a `TypeError`, which does not have a `status`....
> Shouldn't network status be checked in advance? It is checked, but the check is not reliable. Specifically it is subject to false positives: [Navigator.onLine](https://developer.mozilla.org/en-US/docs/Web/API/NavigatorOnLine/onLine). > Regarding checking appart this...
You can check [the spec](https://fetch.spec.whatwg.org/), but almost all errors `fetch()` throws are `TypeError`, and the spec doesn't specify what message should be used. To summarize, most failures result in the...